Integrated: 8295354: Remove G1 incremental non-copy time calculation
Thomas Schatzl
tschatzl at openjdk.org
Mon Nov 7 12:34:08 UTC 2022
On Fri, 4 Nov 2022 14:32:30 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi,
>
> Currently G1 calculates the total non-copy time for young gen incrementally as regions are added to the young gen. The reason for this is that previously getting remembered set size has been expensive (i.e. part of non-copy time).
>
> That is not the case any more since JDK 16 or so.
>
> Further, actually in the calculation the remset work time does not need to be calculated on a per-region basis at all; first, it is incorrect as it does not remove duplicates, and additionally there is/has always been a total remembered set prediction anyway. (Which means the remembered set scan/merge time is considered multiple times).
>
> So all this code can be removed.
>
> Note that this change also fixes the same issue (double-counting of scan/merge time) for survivor regions.
>
> Testing: tier1-3, manual testing wrt to pause time predictions which seem to be slightly better
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: d634ddef
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/d634ddefdd7712f4c3ac070d8493be5ba2de2aef
Stats: 196 lines in 7 files changed: 29 ins; 156 del; 11 mod
8295354: Remove G1 incremental non-copy time calculation
Reviewed-by: ayang, iwalulya
-------------
PR: https://git.openjdk.org/jdk/pull/10987
More information about the hotspot-gc-dev
mailing list