RFR: 8292266: Add JFR event for total Reference processing time [v3]

Albert Mingkun Yang ayang at openjdk.org
Fri Nov 18 19:47:20 UTC 2022


On Fri, 18 Nov 2022 16:53:43 GMT, Sangheon Kim <sangheki at openjdk.org> wrote:

>> Hi all,
>> 
>> Can I have reviews for this change that adds a new JFR event for total Reference Processing time?
>> 
>> The goal is to generate a new JFR event if there is already measured time. This CR doesn't add new time measurement.
>> 
>> Testing: hs-tier1 ~ 3
>> 
>> Thanks,
>> Sangheon
>
> Sangheon Kim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/hotspot/share/jfr/metadata/metadata.xml
>   
>   Co-authored-by: Thomas Schatzl <59967451+tschatzl at users.noreply.github.com>

src/hotspot/share/gc/shared/gcTrace.cpp line 76:

> 74:   send_reference_stats_event(REF_PHANTOM, rps.phantom_count());
> 75: 
> 76:   send_reference_process_time_event(rps.total_process_time());

I think this is called by all collectors, but Z and Shenandoah would have zero for "total process time" here. I am not sure if this causes confusion on reading the jfr reports.

-------------

PR: https://git.openjdk.org/jdk/pull/11230


More information about the hotspot-gc-dev mailing list