RFR: 8297503: Merge FilteringDCTOC into ContiguousSpaceDCTOC [v2]

Albert Mingkun Yang ayang at openjdk.org
Thu Nov 24 11:55:44 UTC 2022


On Wed, 23 Nov 2022 17:56:37 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/shared/space.hpp line 555:
> 
>> 553: class ContiguousSpaceDCTOC : public DirtyCardToOopClosure {
>> 554: protected:
>> 555:   // Overrides.
> 
> Instead of the `overrides` comment, both methods could be decorated with the `override` specifier.

I will do that in another PR for the complete file.

> src/hotspot/share/gc/shared/space.hpp line 577:
> 
>> 575: public:
>> 576:   ContiguousSpaceDCTOC(ContiguousSpace* sp, OopIterateClosure* cl,
>> 577:                        CardTable::PrecisionStyle precision,
> 
> That's a pre-existing (different) issue, but the only `PrecisionStyle` this code is ever used with seems to be `ObjHeadPreciseArray`.

Filed at https://bugs.openjdk.org/browse/JDK-8297572

-------------

PR: https://git.openjdk.org/jdk/pull/11322


More information about the hotspot-gc-dev mailing list