RFR: 8296419: [REDO] JDK-8295319: pending_cards_at_gc_start doesn't include cards in thread buffers [v2]

[Kim Barrett]

On Thu, 24 Nov 2022 10:39:16 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - fix usage of _preserved_marks_set
>>  - rearrange pre-evacuation
>>  - Merge branch 'master' into cards-in-thread-buffers
>>  - retire tlabs before processing thread dcq
>>  - verify empty dirty card logs
>>  - Revert "8296414: [BACKOUT] JDK-8295319: pending_cards_at_gc_start doesn't include cards in thread buffers"
>>    
>>    This reverts commit b847fb687735ae5dff56d12d221556a5218b5bba.
>
> One more typo to fix before pushing.

Thanks for reviews @tschatzl and @kstefanj .

> src/hotspot/share/gc/g1/g1YoungCollector.cpp line 506:
> 
>> 504: void G1YoungCollector::pre_evacuate_collection_set(G1EvacInfo* evacuation_info) {
>> 505:   // Flush early, so later phases don't need to account for per-thread stuff.
>> 506:   // Flushes deferred card marks, so must precede concatenting logs.
> 
> Suggestion:
> 
>   // Flushes deferred card marks, so must precede concatenating logs.

Fixed.  Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/11053