RFR: 8295013: OopStorage should derive from CHeapObjBase [v2]

Kim Barrett kbarrett at openjdk.org
Tue Oct 11 23:21:28 UTC 2022


> Please review this change to OopStorage to derive from CHeapObjBase instead of
> providing its own `operator new` and `operator delete`.
> 
> We also add OopStorage::create factory, so the MEMFLAGS used to allocate the
> storage object will be the same as that passed to its constructor.  This
> required a bunch of fairly mechanical updates to relevant gtests.
> 
> While I was there, also made OopStorage noncopyable.
> 
> Testing: mach5 tier1

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into oopstorage-allocate
 - Merge branch 'master' into oopstorage-allocate
 - OopStorage::create factory and uses CHeapObjBase

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10622/files
  - new: https://git.openjdk.org/jdk/pull/10622/files/ceb94dfa..038f2ec6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10622&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10622&range=00-01

  Stats: 3271 lines in 95 files changed: 2113 ins; 718 del; 440 mod
  Patch: https://git.openjdk.org/jdk/pull/10622.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10622/head:pull/10622

PR: https://git.openjdk.org/jdk/pull/10622



More information about the hotspot-gc-dev mailing list