RFR: 8294847: Fix calculation of G1 effective scanned cards prediction [v3]

Thomas Schatzl tschatzl at openjdk.org
Wed Oct 12 10:33:22 UTC 2022


> Hi all,
> 
>   can I have reviews of this change that fixes the prediction of the actually to be scanned cards?
> 
> In particular, the current code completely misses the log buffer cards in the "effective" number of scanned cards. The change simply assumes that all pending log buffer cards are going to be scanned, ignoring duplicates.
> 
> Other changes are just removing related, unused or unnecessary code.
> 
> Depends on PR#10644, so please review that one first.
> 
> Testing: gha, local testing, tier1-5 with other changes in this patch series, perf testing with other changes in this patch series
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge master
 - kbarrett review
 - initial version
 - initial version

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10647/files
  - new: https://git.openjdk.org/jdk/pull/10647/files/407f0381..fd1fe4f7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10647&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10647&range=01-02

  Stats: 5043 lines in 82 files changed: 3484 ins; 788 del; 771 mod
  Patch: https://git.openjdk.org/jdk/pull/10647.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10647/head:pull/10647

PR: https://git.openjdk.org/jdk/pull/10647



More information about the hotspot-gc-dev mailing list