RFR: 8294847: Fix calculation of G1 effective scanned cards prediction [v4]

Kim Barrett kbarrett at openjdk.org
Thu Oct 13 05:56:09 UTC 2022


On Wed, 12 Oct 2022 10:37:54 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews of this change that fixes the prediction of the actually to be scanned cards?
>> 
>> In particular, the current code completely misses the log buffer cards in the "effective" number of scanned cards. The change simply assumes that all pending log buffer cards are going to be scanned, ignoring duplicates.
>> 
>> Other changes are just removing related, unused or unnecessary code.
>> 
>> Depends on PR#10644, so please review that one first.
>> 
>> Testing: gha, local testing, tier1-5 with other changes in this patch series, perf testing with other changes in this patch series
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Some renaming

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10647



More information about the hotspot-gc-dev mailing list