RFR: 8294775: Shenandoah: reduce contention on _threads_in_evac [v2]
Nick Gasson
ngasson at openjdk.org
Wed Oct 19 17:05:26 UTC 2022
On Tue, 11 Oct 2022 11:57:55 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Refactor
>
> src/hotspot/share/gc/shenandoah/shenandoahEvacOOMHandler.hpp line 92:
>
>> 90: shenandoah_padding(0);
>> 91: struct {
>> 92: volatile jint bits;
>
> The bits field needs a comment saying that it combines a counter with an OOM bit. In-fact, it would probably benefit from a little bit of refactoring, make it a class, and move accessors and relevant methods into it, and avoid public access to the field?
I'm not sure if it's exactly what you intended, but I had a go at refactoring it in the last commit.
-------------
PR: https://git.openjdk.org/jdk/pull/10573
More information about the hotspot-gc-dev
mailing list