RFR: 8293492: ShenandoahControlThread missing from hs-err log and thread dump

Ashutosh Mehra duke at openjdk.org
Thu Sep 8 14:12:44 UTC 2022


On Thu, 8 Sep 2022 06:30:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Please review this patch to add ShenandoahControlThread to the thread list in hs_err log file and thread dump.
>> 
>> With this change, the hs_err log file contains the entry for `ShenandoahControlThread` in "Other Threads" section:
>> 
>> 
>> Other Threads:
>> =>0x00007f84d41c5d50 VMThread "VM Thread" [stack: 0x00007f84d8e8e000,0x00007f84d8f8e000] [id=278151]
>>   0x00007f84d42d5e00 WatcherThread "VM Periodic Task Thread" [stack: 0x00007f84d8280000,0x00007f84d8380000] [id=278163]
>>   0x00007f84d4107d80 ConcurrentGCThread "Shenandoah Control Thread" [stack: 0x00007f84d933a000,0x00007f84d943a000] [id=278150]
>>   0x00007f84d40b4dc0 WorkerThread "Shenandoah GC Threads#0" [stack: 0x00007f84d97bc000,0x00007f84d98bc000] [id=278145]
>>   ...
>> 
>> and Thread.print command (using jcmd) also has the entry for the thread:
>> 
>> 
>> "VM Thread" os_prio=0 cpu=0.46ms elapsed=6.85s tid=0x00007fe6dc1ca750 nid=265830 runnable  
>> 
>> "Shenandoah Control Thread" os_prio=0 cpu=13.34ms elapsed=6.87s tid=0x00007fe6dc10c780 nid=265829 runnable
>> 
>> "Shenandoah GC Threads#0" os_prio=0 cpu=0.12ms elapsed=6.91s tid=0x00007fe6dc0b3730 nid=265827 runnable  
>> 
>> 
>> 
>> I also cleaned up the code a bit to be consistent naming this thread.
>> 
>> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> Looks fine, thanks!

@shipilev @zhengyu123 thanks for reviewing the changes and sponsoring it.

-------------

PR: https://git.openjdk.org/jdk/pull/10205



More information about the hotspot-gc-dev mailing list