RFR: 8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN [v2]

[Thomas Schatzl]

On Wed, 14 Sep 2022 13:21:06 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   lkorinth suggestion
>
> test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java line 245:
> 
>> 243:         PerfCounterSnapshot snap2 = new PerfCounterSnapshot();
>> 244: 
>> 245:         final int MaxAttempts = 10;
> 
> This should be used or removed as well, right?

`MaxAttempts` is used in the code. I prefer to have a named constant than a raw embedded value almost every time, also this time, but I can be convinced to inline it as well. Declaring it in the for-loop only clutters the loop body.

-------------

PR: https://git.openjdk.org/jdk/pull/10239