RFR: 8292296: Use multiple threads to process ParallelGC deferred updates [v2]

Albert Mingkun Yang ayang at openjdk.org
Wed Sep 21 10:00:48 UTC 2022


On Wed, 21 Sep 2022 09:38:19 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make assert more strict
>
> src/hotspot/share/gc/parallel/psParallelCompact.cpp line 2611:
> 
>> 2609: 
>> 2610:   cm->update_contents(cast_to_oop(addr));
>> 2611:   assert(oopDesc::is_oop(cast_to_oop(addr)), "Expected an oop at " PTR_FORMAT, p2i(cast_to_oop(addr)));
> 
> I believe this can be moved up a bit, e.g. btw L2601 and L2602.

Never mind; the assert should be after the obj body is properly updated. It's good as is.

-------------

PR: https://git.openjdk.org/jdk/pull/10313



More information about the hotspot-gc-dev mailing list