RFR: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics [v2]

[Ashutosh Mehra]

On Wed, 14 Sep 2022 18:55:55 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Use HeapAccess instead of RawAccess when iterating the heap objects
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>>  - Make oop_store_common() as private method and remove extraneous condition
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp line 179:
> 
>> 177: 
>> 178:     template <typename T>
>> 179:     static void oop_store_common(T* addr, oop value);
> 
> This is an implementation detail and a public part of the barrier set. We wouldn't expect users - other than the two existing callers - to ever use this api.
> 
> Can it be refactored out of this header and kept entirely within shenandoahBarrierSet.inline.hpp?

I have made `oop_store_common` a private method. It needs to be part of `ShenandoahBarrierSet::AccessBarrier` to be able to access `RawAccessBarrier::oop_store()`.

-------------

PR: https://git.openjdk.org/jdk/pull/10268