RFR: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics [v3]
Dan Heidinga
heidinga at openjdk.org
Fri Sep 23 15:49:18 UTC 2022
On Fri, 23 Sep 2022 15:43:22 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp line 179:
>>
>>> 177:
>>> 178: template <typename T>
>>> 179: static void oop_store_common(T* addr, oop value);
>>
>> This is an implementation detail and a public part of the barrier set. We wouldn't expect users - other than the two existing callers - to ever use this api.
>>
>> Can it be refactored out of this header and kept entirely within shenandoahBarrierSet.inline.hpp?
>
> @DanHeidinga are you okay with the updates?
Looks good to me
-------------
PR: https://git.openjdk.org/jdk/pull/10268
More information about the hotspot-gc-dev
mailing list