RFR: 8294059: Serial: Refactor GenCollectedHeap::collect
Stefan Johansson
sjohanss at openjdk.org
Wed Sep 28 08:18:21 UTC 2022
On Tue, 20 Sep 2022 10:53:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Simple cleanup of control flow in `GenCollectedHeap::collect`.
>
> Test: hotspot_gc
Nice cleanup.
src/hotspot/share/gc/shared/genCollectedHeap.cpp line 837:
> 835: || (cause == GCCause::_gc_locker)
> 836: DEBUG_ONLY(|| (cause == GCCause::_scavenge_alot))
> 837: ;
I would prefer the semi-colon on the same line as the DEBUG_ONLY, but that's just my preference.
Suggestion:
DEBUG_ONLY(|| (cause == GCCause::_scavenge_alot));
-------------
Marked as reviewed by sjohanss (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10355
More information about the hotspot-gc-dev
mailing list