RFR: 8305370: Inconsistent use of for_young_only_phase parameter in G1 predictions

[Thomas Schatzl]

On Fri, 31 Mar 2023 14:55:33 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this change to fix some inconsistent use of `for_young_only_phase`: some methods that require it are not passed that parameter, and some methods, although getting passed that parameter partially re-load that value from collector state.
>> 
>> Fwiw, I am aware that `G1Policy::predict_region_total_time_ms` only ever gets passed `false` as this parameter. I would have changed that as well if some [upcoming change](https://github.com/openjdk/jdk/commit/6c2f18eba29ad9f6e4e5ed28f1521037fdc49398) did not use other values as well. We can always remove it later if not necessary, but if somebody insists on doing so I will do that as well (probably separately).
>> 
>> Testing: gha
>> 
>> Thanks,
>>   Thomas
>
> Lgtm!

Thanks @walulyai @kimbarrett for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13267#issuecomment-1503678190