RFR: 8305716: Enhancements for printing age tables

Thomas Schatzl tschatzl at openjdk.org
Mon Apr 17 10:32:33 UTC 2023


On Thu, 6 Apr 2023 18:18:54 GMT, William Kemper <wkemper at openjdk.org> wrote:

> In order to reduce the number of changes for the upcoming PR for the generational mode for Shenandoah we are opening separate PRs for the changes in common code. Shenandoah will be using this `AgeTable` class. There are two changes here:
> * `AgeTables` created with global=false will no longer SEGV when printing
> * A method was added to allow the `AgeTable` to print to an existing output stream

src/hotspot/share/gc/shared/ageTable.cpp line 118:

> 116: void AgeTable::print_on(outputStream* st, uint tenuring_threshold) {
> 117:   st->print_cr("Age table with threshold %u (max threshold " UINTX_FORMAT ")",
> 118:            tenuring_threshold, MaxTenuringThreshold);

Suggestion:

  st->print_cr("Age table with threshold %u (max threshold " UINTX_FORMAT ")",
               tenuring_threshold, MaxTenuringThreshold);

arguments should be aligned after the bracket above

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13377#discussion_r1168490409


More information about the hotspot-gc-dev mailing list