RFR: 8057586: Explicit GC ignored if GCLocker is active [v4]

Thomas Schatzl tschatzl at openjdk.org
Mon Apr 17 11:42:40 UTC 2023


On Mon, 3 Apr 2023 15:28:58 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi All,
>> 
>> Please review this change to guarantee that at least a Full GC is executed between the invocation and return of `System.gc` or `WhiteBox.fullGC`, even if the call is concurrent with an active `GCLocker `. 
>> 
>> The change should also handle the issues reported in JDK-8299276.
>> 
>> Split into 3 commits, one commit for changes to each GC in [G1, Parallel, Serial]. 
>> 
>> Testing: Tier 1-5.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Albert review

Marked as reviewed by tschatzl (Reviewer).

src/hotspot/share/gc/parallel/psVMOperations.hpp line 48:

> 46:   virtual VMOp_Type type() const { return VMOp_ParallelGCSystemGC; }
> 47:   virtual void doit();
> 48:   bool full_gc_succeeded() const { return _full_gc_succeeded; }

Could we name this `gc_succeeded` like in g1?

-------------

PR Review: https://git.openjdk.org/jdk/pull/13191#pullrequestreview-1387778224
PR Review Comment: https://git.openjdk.org/jdk/pull/13191#discussion_r1168514044


More information about the hotspot-gc-dev mailing list