RFR: 8305062: Refactor CardTable::resize_covered_region

Thomas Schatzl tschatzl at openjdk.org
Tue Apr 18 09:06:51 UTC 2023


On Tue, 18 Apr 2023 08:31:58 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> > They are not used in the hotspot agent afaict though, so they could simply be removed.
> 
> I will explore that option in another PR.
> 

Okay.

> > One option could be to introduce some TwoGenerationCardTable class that is used by serial/parallel which can add these methods/members.
> 
> I think that complicates the inheritance hierarchy too much without real benefit.

It makes code only used by serial/parallel serial/parallel specific, decluttering this base class. But I have not looked through that in detail, and this change already removes lots of unnecessary genericity, so I'm not insisting on that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13206#issuecomment-1512725695


More information about the hotspot-gc-dev mailing list