RFR: 8306833: Change CardTable::_covered to static array [v2]
Kim Barrett
kbarrett at openjdk.org
Wed Apr 26 03:47:23 UTC 2023
On Tue, 25 Apr 2023 14:54:43 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> src/hotspot/share/gc/g1/g1BarrierSet.hpp line 52:
>>
>>> 50: void invalidate(JavaThread* thread, MemRegion mr);
>>> 51:
>>> 52: ~G1BarrierSet() = default;
>>
>> Why is this being privatized?
>
> To minimize the public API; it doesn't need to be public.
It should be public - this is a directly instantiated class. Yes, I know we don't currently call it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13636#discussion_r1177298729
More information about the hotspot-gc-dev
mailing list