RFR: 8310311: Serial: move Generation::contribute_scratch to DefNewGeneration [v2]
Albert Mingkun Yang
ayang at openjdk.org
Tue Aug 1 08:48:48 UTC 2023
On Mon, 31 Jul 2023 13:17:06 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Dropped `static`. `constexpr` makes it more a num literal. (The generated release asm is identical anyway.)
>
> I think constexpr doesn't do anything here beyond what const would do. I'm not sure about this, but
> I think I'd prefer to reserve the use of constexpr only where it (might) matter.
Changed to const, but I still believe constexpr should be used for all compile-time known values.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14540#discussion_r1280300925
More information about the hotspot-gc-dev
mailing list