RFR: 8140326: G1: Consider putting regions where evacuation failed into next collection set [v10]

[Thomas Schatzl]

On Thu, 3 Aug 2023 11:57:55 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update retained region's top/stats at the end only; move pre_concurrent_start to before determining collection set to simplify condition what regions to set tams for
>
> src/hotspot/share/gc/g1/g1Policy.cpp line 270:
> 
>> 268:     desired_eden_length_by_mmu = calculate_desired_eden_length_by_mmu();
>> 269: 
>> 270:     double base_time_ms = predict_base_time_ms(pending_cards, rs_length, true /* include_retained */);
> 
> Can "retained_time" be accounted for inside `calculate_desired_eden_length_by_pause`? It's kind of confusing that  the content of"base time" is context sensitive.

I know, the main reason for this somewhat complicated use is that I wanted to keep a single log message containing all relevant information. I'll look into this again, but not seeing an obviously better option.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14220#discussion_r1283407671