RFR: 8313224: Avoid calling JavaThread::current() in MemAllocator::Allocation constructor [v3]

[Coleen Phillimore]

On Fri, 11 Aug 2023 00:09:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Summary: Avoid calling `JavaThread::current()` since we already have a `Thread*` in `MemAllocator::_thread`.
>> 
>> Although the latter is declared to be a `Thead*` and not a `JavaThread*`, the calling context requires the current thread to be a `JavaThread`, and  `MemAllocator::_thread` was initialized to be  `Thread::current`, so I changed the code from 
>> 
>> 
>> _thread(JavaThread::current()),
>> 
>> 
>> to
>> 
>> 
>> assert(Thread::current()->is_Java_thread(), "must be used by JavaThreads only");
>> assert(Thread::current() == allocator._thread, "do not pass MemAllocator across threads");
>> _thread = JavaThread::cast(allocator._thread);
>> 
>> 
>> I also clean up a few other lines to limit the explicit use of `JavaThread*`.
>> 
>> This fix improved `java --version` by about 0.6% for my prototype of [JDK-8310823](https://bugs.openjdk.org/browse/JDK-8310823), which allocates ~24000 heap objects at VM start-up.
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - @coleenp comments
>  - Merge branch 'master' into 8313224-avoid-JavaThread-current-in-MemAllocator
>  - @tschatzl comments
>  - 8313224: Avoid calling JavaThread::current() in MemAllocator::Allocation constructor

Looks good to me.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15058#pullrequestreview-1572903619