Integrated: 8313224: Avoid calling JavaThread::current() in MemAllocator::Allocation constructor
Ioi Lam
iklam at openjdk.org
Fri Aug 11 03:59:28 UTC 2023
On Thu, 27 Jul 2023 18:34:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> Summary: Avoid calling `JavaThread::current()` since we already have a `Thread*` in `MemAllocator::_thread`.
>
> Although the latter is declared to be a `Thead*` and not a `JavaThread*`, the calling context requires the current thread to be a `JavaThread`, and `MemAllocator::_thread` was initialized to be `Thread::current`, so I changed the code from
>
>
> _thread(JavaThread::current()),
>
>
> to
>
>
> assert(Thread::current()->is_Java_thread(), "must be used by JavaThreads only");
> assert(Thread::current() == allocator._thread, "do not pass MemAllocator across threads");
> _thread = JavaThread::cast(allocator._thread);
>
>
> I also clean up a few other lines to limit the explicit use of `JavaThread*`.
>
> This fix improved `java --version` by about 0.6% for my prototype of [JDK-8310823](https://bugs.openjdk.org/browse/JDK-8310823), which allocates ~24000 heap objects at VM start-up.
This pull request has now been integrated.
Changeset: 43462a36
Author: Ioi Lam <iklam at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/43462a36ab02b67d426c04d345868bd420b30c25
Stats: 15 lines in 2 files changed: 3 ins; 0 del; 12 mod
8313224: Avoid calling JavaThread::current() in MemAllocator::Allocation constructor
Reviewed-by: tschatzl, coleenp
-------------
PR: https://git.openjdk.org/jdk/pull/15058
More information about the hotspot-gc-dev
mailing list