RFR: 8311639: Replace currentTimeMillis() with nanoTime() in jtreg/gc [v3]

Albert Mingkun Yang ayang at openjdk.org
Fri Aug 18 12:38:23 UTC 2023


On Fri, 18 Aug 2023 12:38:03 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> I have removed usage of `currentTimeMillis()` in jtreg/gc as `currentTimeMillis()` is not monotonic. It is mostly changing from milliseconds to nanoseconds. In certain places, I have changed the code from something like `(instant1 < instant2)` to `(instant1 - instant2 < 0)` It might look like I am removing instant2 from both sides of the inequality and the result ought to be the same, but due to overflow arithmetic, the change should be better if nanoseconds where to overflow. I have also removed some loops where the loop is doing nothing except sleeping. I somewhat shortened the string in the key of a hash map because the nanosecond value made the string too long for the heap size.
>> 
>> All tests within jtreg/gc passes.
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
> 
>   printing unparsed values

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15331#pullrequestreview-1584491156


More information about the hotspot-gc-dev mailing list