Integrated: 8311639: Replace currentTimeMillis() with nanoTime() in jtreg/gc
Leo Korinth
lkorinth at openjdk.org
Mon Aug 21 12:22:40 UTC 2023
On Thu, 17 Aug 2023 15:56:04 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
> I have removed usage of `currentTimeMillis()` in jtreg/gc as `currentTimeMillis()` is not monotonic. It is mostly changing from milliseconds to nanoseconds. In certain places, I have changed the code from something like `(instant1 < instant2)` to `(instant1 - instant2 < 0)` It might look like I am removing instant2 from both sides of the inequality and the result ought to be the same, but due to overflow arithmetic, the change should be better if nanoseconds where to overflow. I have also removed some loops where the loop is doing nothing except sleeping. I somewhat shortened the string in the key of a hash map because the nanosecond value made the string too long for the heap size.
>
> All tests within jtreg/gc passes.
This pull request has now been integrated.
Changeset: 17a19dc0
Author: Leo Korinth <lkorinth at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/17a19dc06062331c954fa519a4f668664b1533c9
Stats: 127 lines in 17 files changed: 2 ins; 15 del; 110 mod
8311639: Replace currentTimeMillis() with nanoTime() in jtreg/gc
Reviewed-by: stefank, ayang
-------------
PR: https://git.openjdk.org/jdk/pull/15331
More information about the hotspot-gc-dev
mailing list