RFR: 8315219: G1: Improve allocator pathological case where it keeps doing direct allocations instead of retiring a PLAB [v3]

[Hamlin Li]

On Wed, 30 Aug 2023 10:50:43 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this change to improve on how G1 deals with ParallelGCBufferWastePct. Currently, any allocations larger than  ParallelGCBufferWastePct of the current PLAB size are allocated directly without regard for the state of the current PLAB.  This creates a pathological case where fully used up PLAB are not retired given that allocation sizes larger than ParallelGCBufferWastePct current PLAB.
>> 
>> In this change, we directly check whether the current PLAB can be retired i.e. the remaining PLAB space is < ParallelGCBufferWastePct of current PLAB size. This should reduce the number of direct allocations.
>> 
>> Testing: - mach5 Tier 1-6
>>               - No regression was observed on perf benchmarks
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Albert Review

LGTM.

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15482#pullrequestreview-1603335613