RFR: 8321242: Enable WorkerThreads to run tasks in caller thread [v3]
Aleksey Shipilev
shade at openjdk.org
Wed Dec 6 12:45:53 UTC 2023
> `WorkerThreads` is a generic abstraction that allows running the task in multiple threads. There are cases, however, when we only ask for a single thread to carry the computation, and we can accept the caller running the computation instead of ping-ponging with the worker thread. As rendezvous with worker thread is a potential latency hiccup, we would like to avoid delegating work to worker threads unnecessarily. This improves latency on critical paths: the usual round-trip takes about 10..50us on systems I tried.
>
> Nominally, we would like to handle the case for 1 worker requested. But I would argue we would also like to do this even if we are requesting N (N > 1) threads to carry the compute. We can submit (N-1) tasks to workers, and execute the other task in the caller. For lower N-s, this removes additional rendezvous point with workers, and allows caller to complete the bulk of the work while workers are waking up. This would also simplify testing: if caller path is always taken, this would verify the task can indeed be executed by caller.
>
> We cannot, however, do this optimization unconditionally, because the caller thread might not be set up in the same way as workers are, and executing the code in caller might cause bugs. Therefore, it would be nice to have the opt-in option that allows running in caller thread. Since this looks to be the property of the task, I added it to task definition.
>
> This PR is only the infrastructure code additions, without product code behavior changes. New option is sanity-tested by new gtest. Other PRs can then opt-in tasks into this, for example #16882.
>
> Additional testing:
> - [x] New gtest
> - [x] Linux x86_64 server fastdebug, `tier{1,2,3}`
> - [x] Linux AArch64 server fastdebug, `tier{1,2,3}`
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
- More test updates
- Always run at least one task in caller, if possible
- Split out performance test
- Better test
- Merge branch 'master' into JDK-8321242-worker-threads-caller-runs
- Remove priority adjustment
- More touchups
- Merge branch 'master' into JDK-8321242-worker-threads-caller-runs
- Allow caller to execute more than one task. Allow workers to take all tasks before caller is able to act.
- Atomic touchups
- ... and 3 more: https://git.openjdk.org/jdk/compare/7f139d60...99060fe9
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/16945/files
- new: https://git.openjdk.org/jdk/pull/16945/files/3ee12912..99060fe9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=16945&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=16945&range=01-02
Stats: 79263 lines in 1518 files changed: 35688 ins; 37829 del; 5746 mod
Patch: https://git.openjdk.org/jdk/pull/16945.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16945/head:pull/16945
PR: https://git.openjdk.org/jdk/pull/16945
More information about the hotspot-gc-dev
mailing list