RFR: 8320864: Serial: Extract out Full GC related fields from ContiguousSpace [v2]

Albert Mingkun Yang ayang at openjdk.org
Tue Dec 12 09:30:02 UTC 2023


> Simple moving some fields from the generic class to Full GC specific files.
> 
> Ideally, on deciding wheter `to`-space should be compacted, one should use `set_incremental_collection_failed` to check if promotion-failure occurred during young-gc, but in some places, this flag is set even in the absence of promotion-failure, e.g. `heap->set_incremental_collection_failed(); // Slight lie: we did not even attempt one`. Therefore, I used `next_compaction_space` for this purpose, in order to keep this patch more focused and the diff-size small.
> 
> Test: tier1-5; perf neutral using the attached benchmark.

Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  s1-full-gc

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16842/files
  - new: https://git.openjdk.org/jdk/pull/16842/files/5cd588cd..a33d170a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16842&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16842&range=00-01

  Stats: 108913 lines in 2143 files changed: 58815 ins; 42173 del; 7925 mod
  Patch: https://git.openjdk.org/jdk/pull/16842.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16842/head:pull/16842

PR: https://git.openjdk.org/jdk/pull/16842


More information about the hotspot-gc-dev mailing list