RFR: 8321808: G1: Use unsigned type for non-negative G1 flags

Thomas Schatzl tschatzl at openjdk.org
Tue Dec 12 10:03:16 UTC 2023


On Mon, 11 Dec 2023 16:46:12 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple type update for some G1 flags.

Lgtm. Please fix the spacing issue before integrating.

src/hotspot/share/gc/g1/g1_globals.hpp line 120:

> 118:           range(0, 100)                                                     \
> 119:                                                                             \
> 120:   product(uintx, G1SummarizeRSetStatsPeriod, 0, DIAGNOSTIC,                  \

Spacing before the `` is wrong (2x).

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17063#pullrequestreview-1777091041
PR Review Comment: https://git.openjdk.org/jdk/pull/17063#discussion_r1423754921


More information about the hotspot-gc-dev mailing list