RFR: 8317007: Add bulk removal of dead nmethods during class unloading [v7]

Thomas Schatzl tschatzl at openjdk.org
Fri Dec 15 13:59:42 UTC 2023


On Fri, 15 Dec 2023 13:47:02 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   iwalulya review, renamings
>
> src/hotspot/share/code/nmethod.cpp line 1476:
> 
>> 1474: 
>> 1475:   CodeBlob::purge(free_code_cache_data, unregister_nmethod);
>> 1476:   if (free_code_cache_data) {
> 
> This is effectively `true`.

Please be more specific adding an actual suggestion. I have no idea what this statement means or what you expect here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16767#discussion_r1428003345


More information about the hotspot-gc-dev mailing list