RFR: 8322255: Generational ZGC: Improve heuristics about page size

Thomas Schatzl tschatzl at openjdk.org
Mon Dec 18 09:19:38 UTC 2023


On Sun, 17 Dec 2023 15:37:25 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch fixes several issues about heuristics.
> 
> 1. Move `ZHeuristics::set_medium_page_size` to `ZArguments::initialize` so that the setting of `MaxTenuringThreshold` can use `ZPageSizeMedium` correctly.
> 2. Fix `ZHeuristics::use_per_cpu_shared_small_pages` to meet its comment.
> 3. Fix `ZHeuristics::significant_heap_overhead` and `ZHeuristics::significant_young_overhead` to use `ZFragmentationLimit` and `ZYoungCompactionLimit` as percentages instead of multiples.
> 
> Thanks for the review.
> 
> Best Regards,
> -- Guoxiong

Would it be possible to split these different issues into separate PRs?

They look like different bugs.

-------------

Changes requested by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17137#pullrequestreview-1786259417


More information about the hotspot-gc-dev mailing list