RFR: 8293623: Simplify G1ConcurrentRefineThreadControl [v9]

Thomas Schatzl tschatzl at openjdk.org
Mon Dec 18 11:22:42 UTC 2023


On Sat, 16 Dec 2023 12:52:09 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:

>> 8293623: Simplify G1ConcurrentRefineThreadControl
>
> Lei Zaakjyu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refactor

Some minor suggestions.

src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 126:

> 124:   for (uint i = 0; i < (uint)_threads.length(); i++) {
> 125:     tc->do_thread(_threads.at(i));
> 126:   }

Suggestion:

  for (Thread* t : _threads) {
    tc->do_thread(t);
  }

src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 132:

> 130:   for (uint i = 0; i < (uint)_threads.length(); i++) {
> 131:     _threads.at(i)->stop();
> 132:   }

Suggestion:

  for (Thread* t : _threads) {
    t->stop();
  }

Iterator syntactic sugar is nicer here imo...

-------------

Changes requested by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17077#pullrequestreview-1786608845
PR Review Comment: https://git.openjdk.org/jdk/pull/17077#discussion_r1429944395
PR Review Comment: https://git.openjdk.org/jdk/pull/17077#discussion_r1429943988


More information about the hotspot-gc-dev mailing list