RFR: 8322255: Generational ZGC: ZPageSizeMedium should be set before MaxTenuringThreshold [v2]

Erik Österlund eosterlund at openjdk.org
Mon Dec 18 13:06:38 UTC 2023


On Mon, 18 Dec 2023 11:18:53 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch fixes several issues about heuristics.
>> 
>> 1. Move `ZHeuristics::set_medium_page_size` to `ZArguments::initialize` so that the setting of `MaxTenuringThreshold` can use `ZPageSizeMedium` correctly.
>> 2. Fix `ZHeuristics::use_per_cpu_shared_small_pages` to meet its comment.
>> 3. Fix `ZHeuristics::significant_heap_overhead` and `ZHeuristics::significant_young_overhead` to use `ZFragmentationLimit` and `ZYoungCompactionLimit` as percentages instead of multiples.
>> 
>> Thanks for the review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unrelated change.

Looks good.

-------------

Marked as reviewed by eosterlund (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17137#pullrequestreview-1786854484


More information about the hotspot-gc-dev mailing list