RFR: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM

[David Holmes]

On Tue, 19 Dec 2023 10:08:14 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this change that changes the filler array class name (again) after user feedback.
> 
> In particular, the previous name `Ljdk/internal/vm/FillerArray;` confuses some tools (https://github.com/oracle/visualvm/issues/523). I.e. it's not an array, but still variable sized.
> This change adds the `[` array bracket, and renames the element name to not have `Array` inside to not try to pretend that the element is some other kind of array.
> 
> Testing: tier1-6
> 
> Thanks,
>   Thomas

I'm still struggling with what we are doing with this filler array stuff. IIUC the underlying type is actually `int[]` but we pretend it is `FillerElement[]`. Won't exposing this fake type just lead to further problems if tools try to inspect one of these arrays as-if it were an `Object[]` ??

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17155#issuecomment-1863767089