RFR: 8322503: Shenandoah: Clarify gc state usage

[Y. Srinivas Ramakrishna]

On Tue, 19 Dec 2023 21:41:04 GMT, William Kemper <wkemper at openjdk.org> wrote:

> This is a follow up to https://github.com/openjdk/jdk/pull/17112.

Marked as reviewed by ysr (Reviewer).

src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 301:

> 299:   char gc_state() const;
> 300:   void propagate_gc_state_to_java_threads();
> 301:   bool has_gc_state_changed() const { return _gc_state_changed; }

The name changes per @shipilev look good. If we have a sentence of documentation in the header file for each of these methods, that makes things even clearer (and is not subject to limitations on the length of the method name :-)

-------------

PR Review: https://git.openjdk.org/jdk/pull/17163#pullrequestreview-1791732278
PR Review Comment: https://git.openjdk.org/jdk/pull/17163#discussion_r1433228905