RFR: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy

[Thomas Schatzl]

On Wed, 20 Dec 2023 10:13:43 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial removing dead code.

Changes requested by tschatzl (Reviewer).

src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp line 591:

> 589:     // *desired_eden_size_ptr = *desired_eden_size_ptr + eden_heap_delta;
> 590:     set_change_young_gen_for_min_pauses(
> 591:       increase_young_gen_for_min_pauses_true);

Removing this setter (and other similar ones) changes the values of the externally observable performance counters. Not sure if this has been intended. I suggest keeping removng this "EXPERIMENTAL ADJUST" comment separate from externally visible changes.

The "    // Only record that the estimator indicated such an action." part of the comment also seems not to be part of the "experimental adjustment" comment.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17166#pullrequestreview-1793058206
PR Review Comment: https://git.openjdk.org/jdk/pull/17166#discussion_r1434131019