RFR: 8233443: G1 DetailedUsage class names overly generic for global namespace

[Guoxiong Li]

On Fri, 22 Dec 2023 15:47:02 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:

> Description:
> The classes DetailedUsage and DetailedUsageClosure are defined in G1HeapTransitions.cpp. These class names seem a bit generic for the global namespace. They could be G1-prefixed, but I think better would be to make them nested classes of G1HeapTransition. Just declare them in that class, with the definitions still in the .cpp file.

LGTM.

During reviewing this patch, I notice the static method `g1HeapTransition.cpp::log_regions` is only used at `G1HeapTransition::print`. Should it also be moved into `G1HeapTransition`?

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17186#pullrequestreview-1798002752