RFR: 8322296: Introduce CardWord for word iteration on CardTable [v2]

Guoxiong Li gli at openjdk.org
Thu Dec 28 13:23:49 UTC 2023


On Thu, 21 Dec 2023 20:58:36 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - review
>>  - Merge branch 'master' into card-word
>>  - card-word
>
> src/hotspot/share/gc/shared/cardTable.hpp line 94:
> 
>> 92:   virtual ~CardTable() = default;
>> 93: 
>> 94:   static bool is_word_aligned(const CardValue* const card) {
> 
> Maybe is_word_aligned => is_card_word_aligned?  The existing name seems overly generic, and has other
> (semantic, though probably not operational) meanings elsewhere.

There is a similar method named `is_card_aligned`. So the `is_card_word_aligned` seems more consistent and better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17144#discussion_r1437664230


More information about the hotspot-gc-dev mailing list