RFR: 8233443: G1 DetailedUsage class names overly generic for global namespace
Guoxiong Li
gli at openjdk.org
Thu Dec 28 15:41:45 UTC 2023
On Fri, 22 Dec 2023 15:47:02 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:
> Description:
> The classes DetailedUsage and DetailedUsageClosure are defined in G1HeapTransitions.cpp. These class names seem a bit generic for the global namespace. They could be G1-prefixed, but I think better would be to make them nested classes of G1HeapTransition. Just declare them in that class, with the definitions still in the .cpp file.
> Your change (at version [b7d0559](https://github.com/openjdk/jdk/commit/b7d0559887f4fa2c305343179b0abcd53e467fb8)) is now ready to be sponsored by a Committer.
A non-trivial patch of the hotspot needs at least two reviewers to review. The formal reviewer didn't mark this patch as trivial, so please wait for another formal reviewer to approve this patch. Until then, I can't sponsor this patch for you. You can read the following links for more information.
[1] https://openjdk.org/guide/#working-with-pull-requests
[2] https://openjdk.org/bylaws#reviewer
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17186#issuecomment-1871283214
More information about the hotspot-gc-dev
mailing list