RFR: 8322278: Generational ZGC: Adjust ZHeuristics::use_per_cpu_shared_small_pages to meet its comment

Kim Barrett kbarrett at openjdk.org
Thu Dec 28 22:14:47 UTC 2023


On Mon, 18 Dec 2023 11:17:33 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This trivial patch fixes the method `ZHeuristics::use_per_cpu_shared_small_pages` to meet its comment.
> 
> Thanks for the review.
> 
> Best Regards,
> -- Guoxiong

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/z/zHeuristics.cpp line 66:

> 64:   // of the max heap size. Otherwise fall back to using a single shared small
> 65:   // page. This is useful when using small heaps on large machines.
> 66:   const size_t per_cpu_share = (MaxHeapSize * 0.03125) / ZCPU::count();

The proposed change just reverts what appears to have been an intentional code
change in JDK-8307058. That change should have updated the comment.  So I
don't think this change should be made.  The comment should be fixed instead.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17138#pullrequestreview-1798456273
PR Review Comment: https://git.openjdk.org/jdk/pull/17138#discussion_r1437900768


More information about the hotspot-gc-dev mailing list