RFR: 8322278: Generational ZGC: Adjust ZHeuristics::use_per_cpu_shared_small_pages to meet its comment
Guoxiong Li
gli at openjdk.org
Fri Dec 29 03:46:49 UTC 2023
On Thu, 28 Dec 2023 22:48:06 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:
>> src/hotspot/share/gc/z/zHeuristics.cpp line 66:
>>
>>> 64: // of the max heap size. Otherwise fall back to using a single shared small
>>> 65: // page. This is useful when using small heaps on large machines.
>>> 66: const size_t per_cpu_share = (MaxHeapSize * 0.03125) / ZCPU::count();
>>
>> The proposed change just reverts what appears to have been an intentional code
>> change in JDK-8307058. That change should have updated the comment. So I
>> don't think this change should be made. The comment should be fixed instead.
>
> Agreed.
Should I change the title of this issue and fix the comment in this patch? Or open another issue and PR to fix it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17138#discussion_r1437968799
More information about the hotspot-gc-dev
mailing list