RFR: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId

Erik Österlund eosterlund at openjdk.org
Fri Dec 29 14:49:53 UTC 2023


On Thu, 28 Dec 2023 05:56:56 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch adds the GCId to the log of soft reference policy. I move the related code to the start of the old generational GC which needs  to add a parameter `ZDriverRequest` in the method `ZDriverMajor::collect_old`. An alternative, which doesn't need to add a parameter, is only moving the related code to the start of the major GC, concretely the method `ZDriverMajor::gc`. But considering the references only be cleared in old generational GC, I make such decision. Waiting for your opinion on it.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

I guess you could add a bool member variable to the reference processor to remember the choice.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17196#issuecomment-1872143115


More information about the hotspot-gc-dev mailing list