RFR: 8301149: Parallel: Refactor MutableNUMASpace::update_layout [v3]

[Leo Korinth]

On Wed, 1 Feb 2023 16:51:38 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/parallel/mutableNUMASpace.cpp line 281:
> 
>> 279: // Update space layout. Perform adaptation.
>> 280: void MutableNUMASpace::update() {
>> 281:   bool should_initialize = false;
> 
> I think `numa_has_static_binding` should be removed, it is always `true`, correct? If so, the loop can be removed and `should_initialize` can be removed as well. I am unsure if you want to fix these things or you want me to create enhancements for this. It might be possible that if we continue this path and take a better look at `UseAdaptiveNUMAChunkSizing`, the whole `update()` method can be removed and maybe the flag, but I know too little about these flags, and  maybe you want to integrate this as is. If so, I think this looks good, and you can ignore this comment.

Sometimes, it is easier doing stuff incrementally.

-------------

PR: https://git.openjdk.org/jdk/pull/12216