RFR: 8302122: Parallelize TLAB retirement in prologue in G1 [v3]
Thomas Schatzl
tschatzl at openjdk.org
Wed Feb 15 12:49:33 UTC 2023
On Wed, 15 Feb 2023 12:37:08 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> ayang review
>
> src/hotspot/share/gc/g1/g1YoungCollector.cpp line 476:
>
>> 474: G1PreEvacuateCollectionSetBatchTask cl;
>> 475: G1CollectedHeap::heap()->run_batch_task(&cl);
>> 476: phase_times()->record_pre_evacuate_prepare_time_ms((Ticks::now() - start).seconds() * 1000.0);
>
> "PreEvacuate" and "pre_evacuate_prepare" seems too abstract/generic. Maybe sth more concrete to reflect what it is, not how it is connected/compared to its context.
There is intention to put more stuff into that phase (like for the post evacuate tasks), and I would like to avoid (significant) renaming later.
As it looks now there will be a second batch task after evaluating the collection set as there are dependencies on its result (after all) that do not seem to be easily untangled. I would like to put that one into the `g1YoungGCPreEvacuateTasks.hpp` file similar to the post evacuate tasks too, hence the somewhat generic naming.
-------------
PR: https://git.openjdk.org/jdk/pull/12497
More information about the hotspot-gc-dev
mailing list