Integrated: 8302206: Factor out duplicate G1VerificationClosure

[Thomas Schatzl]

On Fri, 10 Feb 2023 12:43:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this cleanup that merges `G1VerifyLiveClosure` from `g1FullGCMarker.cpp` and `VerifyLiveClosure` from `heapRegion.cpp` into a single one as they are virtually identical.
> 
> There is probably one change that needs some discussion, and that is about changing the type and meaning of `G1MaxVerifyFailures`: after changing the type of `G1VerificationClosure::_num_failures` to uint, the given comparison does not work any more due to differing types.
> However the change of the default value to `0` meaning "show all messages" does not seem too bad: even before this change, a value of `0` at least showed one failure as this check (now it shows all messages) is located after the error printing in the closures.
> It's a develop flag too, so instead of casting around I chose to simply change the meaning.
> 
> Testing: gha
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: e971f90a
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e971f90a0b86c07b19d185406fa5db59c4126ebd
Stats:     341 lines in 11 files changed: 114 ins; 192 del; 35 mod

8302206: Factor out duplicate G1VerificationClosure

Reviewed-by: kbarrett, ayang

-------------

PR: https://git.openjdk.org/jdk/pull/12511