RFR: 8302206: Factor out duplicate G1VerificationClosure [v2]

[Thomas Schatzl]

On Mon, 13 Feb 2023 11:44:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>>> > However the change of the default value to 0 meaning "show all messages" does not seem too bad: even before this change, a value of 0 at least showed one failure as this check (now it shows all messages) is located after the error printing in the closures.
>>> 
>>> I find `*Max* == 0` == `show all msg` too surprising. Is it possible to impl the most obvious interpretation, 0 means no msgs at all?
>> 
>> This has been a (somewhat bad) tradeoff between implementation effort for this change and usefulness.
>> 
>> This is a develop flag, i.e. available only when debugging, and not printing any of the errors does not seem useful in that situation (I can hardly see a situation where one runs a debug build to find errors and then suppress all the messages you need for debugging. That corresponds to my use of that flag to set this value to something fairly low to decrease the amount of errors reported to something manageable, but still get an idea whether the issues are limited e.g. to a special type of region, but never to turn them off).
>> 
>> As for proper support of the `0` value, I would like to not implement that at least in this change; as its use is limited, I feel it is not worth the effort and feels out of scope. So I also set the minimum value to 1 instead of 0.
>> 
>> The flag now is a `size_t` and its default `max_uintx` (=`max_size_t`). That makes the interpretation clear I hope.
>
>> This is a develop flag, i.e. available only when debugging, and not printing any of the errors does not seem useful in that situation
> 
> I see.
> 
>> So I also set the minimum value to 1 instead of 0.
> 
> Thanks for the revision.

Thanks @albertnetymk @kimbarrett for your reviews

-------------

PR: https://git.openjdk.org/jdk/pull/12511