RFR: 8300447: Parallel: Refactor PSPromotionManager::drain_stacks_depth [v2]

Kim Barrett kbarrett at openjdk.org
Wed Jan 18 15:56:18 UTC 2023


On Wed, 18 Jan 2023 10:26:30 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/parallel/psPromotionManager.cpp line 231:
> 
>> 229: void PSPromotionManager::drain_stacks_depth(bool totally_drain) {
>> 230:   const uint threshold = totally_drain ? 0
>> 231:                                        : _target_stack_size;
> 
> Feel free to ignore: I would prefer to not spread very simple `?:` statements like this over multiple lines. This is imo less readable than keeping it in a single line (and `?:` statements should always be very small/short anyway).

+1

-------------

PR: https://git.openjdk.org/jdk/pull/12063


More information about the hotspot-gc-dev mailing list