RFR: 8300769: Remove G1CollectionSet::_inc_bytes_used_before

Albert Mingkun Yang ayang at openjdk.org
Fri Jan 20 22:29:03 UTC 2023


On Fri, 20 Jan 2023 13:02:10 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this removal of `G1CollectionSet::_inc_bytes_used_before`; this variable holds the amount of bytes used in eden regions, updated during mutator time. At the start of gc its value is copied to `G1CollectionSet::_bytes_used_before`, and then never touched again. The `_bytes_used_before` is read at end of gc, and then reset.
> 
> This change simply removes `_inc_bytes_used_before` and directly uses `_bytes_used_before` to accumulate eden region used bytes.
> 
> Testing: gha
> 
> Thanks,
>   Thomas

I think `_bytes_used` is enough; the `_before` suffix adds nothing and it's confusing -- there's no counterpart like `_bytes_used_after`.

-------------

Marked as reviewed by ayang (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12113


More information about the hotspot-gc-dev mailing list