RFR: 8299953: Merge ContiguousSpaceDCTOC into DirtyCardToOopClosure

[Thomas Schatzl]

On Wed, 11 Jan 2023 10:09:20 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change of merging a class into its super class.
> 
> Test: hotspot_gc
> 
> PS: `git diff --color-moved=dimmed_zebra` might be useful to see the diff.

Lgtm, please fix the indentation before pushing.

src/hotspot/share/gc/shared/space.cpp line 61:

> 59:       // later card.  Figure out where the object ends.
> 60:       assert(_sp->block_size(top_obj) == cast_to_oop(top_obj)->size(),
> 61:         "Block size and object size mismatch");

Pre-existing: Indentation for the assert message is off.

Suggestion:

      assert(_sp->block_size(top_obj) == cast_to_oop(top_obj)->size(),
             "Block size and object size mismatch");

src/hotspot/share/gc/shared/space.cpp line 149:

> 147:                                                    HeapWord* bottom,    \
> 148:                                                    HeapWord* top,       \
> 149:                                                    ClosureType* cl) {   \

Parameter indentation is off now with the change, also the macro continuation `` characters do not line up any more.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11938