RFR: JDK-8301178: Replace NULL with nullptr in share/gc/epsilon/
Johan Sjölen
jsjolen at openjdk.org
Thu Jan 26 17:04:08 UTC 2023
On Thu, 26 Jan 2023 16:55:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/gc/epsilon/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>
> Here are some typical things to look out for:
>
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>
> An example of this:
>
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
>
>
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
>
> Thanks!
Hi, I consider this patch trivial. Please mention that it is when reviewing so it can be merged with only one approval :-).
-------------
PR: https://git.openjdk.org/jdk/pull/12225
More information about the hotspot-gc-dev
mailing list